Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

ReferrerInfo can be updated by anyone.

p0wd3r

Summary

There is a flaw in updateReferrerInfo that allows anyone to change another user's referralInfo and set the target's referrer to himself.

Vulnerability Details

In updateReferrerInfo, there are two key points:

  1. It only requires _msgSender() != _referrer, the subsequent part has nothing to do with _msgSender.

  2. The info being set is referralInfoMap[_referrer], and referralInfo.referrer = _referrer

This leads to anyone other than _referrer being able to change his referrerRate and authorityRate, and his referrer can only be himself.

https://github.com/Cyfrin/2024-08-tadle/blob/main/src/core/SystemConfig.sol#L41-L72

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
//@audit only not ms, can be anyone else.
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
uint256 referralExtraRate = referralExtraRateMap[_referrer];
uint256 totalRate = baseReferralRate + referralExtraRate;
​
if (totalRate > Constants.REFERRAL_RATE_DECIMAL_SCALER) {
revert InvalidTotalRate(totalRate);
}
​
if (_referrerRate + _authorityRate != totalRate) {
revert InvalidRate(_referrerRate, _authorityRate, totalRate);
}
​
//@audit set _referrer's referrer as _referrer him self
ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;

Impact

This allows anyone to change another user's referralInfo and set the target's referrer to himself.

The referrerRate and authorityRate are used to distribute referrer bonus, and this vulnerability allows anyone to influence the amount of bonus distributed.

Tools Used

vscode

Recommendations

I think ReferralInfo storage referralInfo = referralInfoMap[_referrer];-> ReferralInfo storage referralInfo = referralInfoMap[_msgSender()];is right.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!