Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

insufficient referrer validation, malicious actor can set secondary wallet as referrer to recieve back 30% of platform fee paid

honour

Summary

SystemConfig::updateReferrerInfo allows anyone to set a referrer without any validation , as a result a malicious actor can set a secondary wallet as their referrer and recieve back the 30% of platform fee they pay for any transaction.

Vulnerability Details

SystemConfig::updateReferrerInfo does not have suffucient validation to verify if the referrer is actually a valid referrer

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
uint256 referralExtraRate = referralExtraRateMap[_referrer];
uint256 totalRate = baseReferralRate + referralExtraRate;
​
if (totalRate > Constants.REFERRAL_RATE_DECIMAL_SCALER) {
revert InvalidTotalRate(totalRate);
}
​
if (_referrerRate + _authorityRate != totalRate) {
revert InvalidRate(_referrerRate, _authorityRate, totalRate);
}
​
ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
​
emit UpdateReferrerInfo(
msg.sender,
_referrer,
_referrerRate,
_authorityRate
);
}

It only checks that _msgSender() != _referrer and _referrer is not address(0x0). This means any address can be set as a referrer even if that address doesn't have a referrer id and is not a valid referrer.

Impact

MEDIUM - impact on protocol's generated revenue

Tools Used

Manual Review

Recommendations

  1. SystemConfig::updateReferrerInfo should have access control - like a REFERRER_UPDATER_ROLE to update the referrer info of a user.

  2. Protocol should use off-chain logic to verify that the referrer is valid(perhaps based on the generated referral id) and update the user's referrer info via REFERRER_UPDATER_ROLE account(or bots).

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.