Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

The referrerInfo isn't set properly in SystemConfig.sol::updateReferrerInfo()

456456

Summary

SystemConfig.sol::updateReferrerInfo() improperly gets referralInfoMap[_referrer] instead of referralInfoMap[_msgSender()] which lets a malicious user change any address' referrerInfo.

Vulnerability Details

updateReferrerInfo() is supposed to change the msg.sender's referrerInfo, but incorrectly gets the wrong referrerInfo from referralInfoMap mapping, which in turn lets users change any address' referrerInfo by invoking the function with any address that's not address(0) or msg.sender.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
...
​
@> ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
​
...
}

Impact

Malicious users could change legitimate users' referrerInfo however they like, potentially stealing referrer's rewards from them.

Tools Used

Manual review

Recommendations

Change the code so that it gets referralInfoMap[_msgSender()] instead of referralInfoMap[_referrer].

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.