Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: high
Valid

SystemConfig.sol::updateReferrerInfo() doesn't implement an onlyOwner modifier

Summary

SystemConfig.sol::updateReferrerInfo() doesn't implement an onlyOwner modifier, so any user could access a referrerInfo and change it, potentially stealing referrer's rewards.

Vulnerability Details

SystemConfig.sol::updateReferrerInfo() doesn't implement an onlyOwner modifier or any check that controls access, so malicious users could change any referrerInfo, potentially stealing rewards from honest users.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
@> ) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
...
}

Impact

Malicious users can access referrerInfo and change it how they like

Tools Used

Manual review

Recommendations

Implement access control on the function.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!