Tadle

Summary

A vulnerability exists in the createMarketPlace function where the uniqueness of the _marketPlaceName is not verified. This could lead to conflicts and confusion if multiple marketplaces are created with the same name.

Vulnerability Details

In the createMarketPlace function, inside SystemConfig.sol, the contract fails to check if the provided _marketPlaceName is unique before creating a new marketplace. According to the function's documentation, the marketplace name must be unique, but without this check, the same name could be used for multiple marketplaces, causing potential conflicts and operational issues.

The absence of this check can lead to the creation of multiple marketplaces with the same name, which can cause operational confusion and make it difficult to distinguish between different marketplaces. Which opens a possibility for someone to create an offer in the wrong marketplace.

Impact

Without verifying the uniqueness of _marketPlaceName, the function can create multiple marketplaces with the same name, leading to potential conflicts, confusion, and administrative difficulties.

Tools Used

Imagination

Recommendations

Implement a check to ensure that _marketPlaceName is unique before proceeding with the creation of a new marketplace. This can be done by checking if a marketplace with the same name already exists in the marketPlaceInfoMap for example.