Tadle

Summary

in the settleAskTaker when the _settledPoints is not equal to the points of the stockInfo for the askTaker, it enters the else statement, which incorectly takes the whole collateral of the taker and gives it to the bidMaker which is the offer Authority, without taking into consideration how much points the taker actually settled. And the taker still transfers the settled points to the offerAuthority

Vulnerability Details

settleAskTaker

When it comes to know how much of the points you are actually settling if it is not directly equal to the point of the stock you hold it takes the whole collateral, this would be correct if the function did not still transfer the calculated settlement ten line before this snippet

So we have a situation that when askTakers settle, they pay the settlement amount and if the points are not equal to the stock point they get the whole collateral taken and added to the makers TokenBalanceType.MakerRefund

Impact

The point of collateral is to assign it to the amount of points promised to be delivered by the askTaker, if the collateral gets removed then this causes loss of funds to the taker as they would loos the collateral even though they settled part of the points

Tools Used

manual review

Recommendations

The ratio of the amount of collateral to be removed should be equal to the ratio of settledPoints to the Stockinfo.points, which will accuratley describe how much collateral to add to the offer authority balance and how much to add to the takers balance.