Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

DOS if contract caller reverts on transfer

Summary

Funds of contract participating in the premarket.sol and tokenmanager.sol can become stuck due to

  • not having the fallback function

  • having a fallback function execute another function say, transfer to owner on receive msg.value

Vulnerability Details

Funds of contracts (bundler contracts, contracts built on Tadle premarkets, arb bots, etc) participating in the premarket.sol and tokenmanager.sol can become stuck on withdraw due to

  • not having the fallback function

  • having a fallback function execute another function say, transfer to owner on receive msg.value or emit event due to 2300 hardcoded gas used

This will revert always and cause stuck funds for owner of contract which could be significant depending on the use case. While it has a high impact, it is unlikely as most contracts dealing with eth have fallback functions as a rule of thumb but still possible

Impact

Stuck Funds

Tools Used

Manual Review

Recommendations

  • use .send / .call{value: 2300} instead and on status false, transfer it in weth

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

[invalid] finding-TokenManager-withdraw-transfer-2300-gas

Invalid, known issues [Medium-2](https://github.com/Cyfrin/2024-08-tadle/issues/1)

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!