Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Missing wright access control in `SystemConfig::updateReferrerInfo`. access control vulnerablity

0xrolko

Relevant GitHub Links

https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L41

Summary

The author _authority can theft the fund destined to the referrer _referrer is the access control is not restricted.

Vulnerability Details

The SystemConfig.updateReferrerInfo is used by 2 type of user: _authorityRate user and _referrer. Both used this function to update the reward rate. Because access control to this function is not restricted, the user who has the most rights, i.e. the _authority, can single-handedly take all the reward rates of the referent greater than baseReferralRate.

@> function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
...
}
​

Impact

The fund of the referrer can be steal.

Tools Used

Manual analysis.

Recommendations

Checks that the sender is the owner.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
- ) external {
+ ) external onlyOwner {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
if (_referrerRate < baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
...
}
​
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.