There is no logic to claim makerInfo.platformFee
.
In createTaker()
, it calculates remainingPlatformFee after subtracting referral bonues.
But there is no mechanism to claim this accrued makerInfo.platformFee
.
Possible fund lock in the protocol.
Manual Review
There should be a logic to claim the makerInfo.platformFee
.
Low severity, this can be done using the `Rescuable.sol` contract. Arguably there is no errors here given the `platformFee` variable can represent the historical fees that the protocol has accumulated and need not be updated when fees are withdrawn. However, I believe a more explicit function can be valuable to be more transparent regarding withdrawals. However, I will leave this issue open for escalation for debates because I can see it as arguably invalid as well, but I see no arguments for it being medium severity since there is an alternative to retrieve platform fees, assuming admins are trusted.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.