settleAskTaker()
validates the authority incorrectly.
In settleAskTaker()
, an ask taker might be unable to settle if the status is AskSettling
.
It requres the caller should be the offerInfo.authority
which is incorrect.
The caller should be stockInfo.authority
who has called createTaker()
while matching a maker offer.
An ask taker wouldn't settle the trade due to the incorrect authority validation.
Manual Review
settleAskTaker()
should check if the caller is stockInfo.authority
, not offerInfo.authority
.
Valid high severity, when taker offers are created pointing to a `offer`, the relevant `stockInfoMap` offers are created with the owner of the offer aka `authority`, set as the creater of the offer, as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/PreMarkets.sol#L245). Because of the wrong check within settleAskTaker, it will permanently DoS the final settlement functionality for taker offers for the maker that listed the original offer, essentially bricking the whole functionality of the market i.e. maker will always get refunded the original collateral, and takers will never be able to transact the original points put up by the maker. This occurs regardless of market mode.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.