Submission Details
Severity:
In emergency scenario, owner can not settle ask maker
Vulnerability Details
if (status == MarketPlaceStatus.AskSettling) {
if (_msgSender() != offerInfo.authority) {
revert Errors.Unauthorized();
}
} else {
if (_msgSender() != owner()) {
revert Errors.Unauthorized();
}
if (_settledPoints > 0) { // <-
revert InvalidPoints();
}
}
In settleAskMaker function, when marketplace status is not asksettling, owner still can call settleAskMaker function. But due to checking condition, owner can not call with settledPoint > 0, which does not make any sense when _settledPoint = 0
Impact
Part of function become non-functional due to checking condition
Tools Used
Manual review
Recommendations
Update function to:
- if (_settledPoints > 0) {
+ if (_settledPoints == 0) {
revert InvalidPoints();
}
Prize pool breakdown
Total prize
30,000 USDC
nSLOC
1,22924 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.