Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: medium
Invalid

Incorrect conversion of implicit type

Summary

The Initialize function in the systemConfig contract defines how the structure of the upgraded contract should look like

Vulnerability Details

function initialize(int256 _basePlatformFeeRate, uint256 _baseReferralRate) external onlyOwner {
//@audit Is there a state variable that has the basePlaformFeeRate?
basePlatformFeeRate = _basePlatformFeeRate; //@audit compatible intger
baseReferralRate = _baseReferralRate;
}

The function is meant to set the structure of the contract and converting the _basePlatFormFeeRate can result to implicit type conversion making the system not achieve what it is intended to do.

Impact

Distrubt the purpose of the system by not allowing the right conversion

Tools Used

Manual

Recommendations

Completely convert the int256 _basePlatformFeeRate to a uint

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.