Tadle

Summary

PreMarkets.relistOffer() rounds down how much to deposit

Vulnerability Details

Users can list offers, cancel offers and relist the offers again depositing, withdrawing and depositing collateral again, but through out the codebase, anytime a user wants to deposit the value is rounded up and anytime Userclaimable balance is about to be updated it is rounded down except from this instance PreMarkets.relistOffer() which rounds down how much to deposit because it calls OfferLibraries.getRefundAmount() instead of getDepositAmount(), in certain instances of little amount/point balance in offer it can return zero which will revert in TokenManager.tillIn(), but if it rounded up like other deposit functions it will not revert.

Impact

DOS of PreMarkets.relistOffer()

Tools Used

Manual Review

Recommendations

Call OfferLibraries.getDepositAmount() instead of OfferLibraries.getRefundAmount().