Tadle

Tadle
DeFi
30,000 USDC
View results
Submission Details
Severity: low
Invalid

amount should be compared with 0.

Summary

we are comparing the "params.amount == 0x0" but it should be compared to 0.

Vulnerability Details

function createOffer(CreateOfferParams calldata params) external payable {
/**
* @dev points and amount must be greater than 0
* @dev eachTradeTax must be less than 100%, decimal scaler is 10000
* @dev collateralRate must be more than 100%, decimal scaler is 10000
*/
i@>>f (params.points == 0x0 || params.amount == 0x0) {
revert Errors.AmountIsZero();
}

Impact

the wrong comparison of amount.

Tools Used

Recommendations

amount !=0.

Updates

Lead Judging Commences

0xnevi Lead Judge
10 months ago
0xnevi Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.