SystemConfig::updateReferrerInfo is subject to an access control vulnerability
Summary
Lack of access control check on the SystemConfig::updateReferrerInfo function allow it possible for an author to steal the theft of a partial rewards of the referrer in favour of the authority.
Vulnerability Details
The SystemConfig.updateReferrerInfo function is used to update the reward rate for both the referrer and the author. Anyone (including the authority) can call this function but the referrer and steal any reward rate of the referrer that is above baseReferralRate in favour of the authority.
Impact
It is possible to partially steal the referrer's rewards.
Tools Used
Manual review.
Recommendations
Add the onlyOwner modifier to the function.
Lead Judging Commences
finding-SystemConfig-updateReferrerInfo-msgSender
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.