Summary

The offerStatus is not updated after PreMarktes::CreateTaker

Vulnerability Details

According to the documentation/code natspec, an offerStatus of virgin means the offer doesn't have any takers. But when a taker is created for an offer, the offer status is not updated from virgin and used like that through out the code.

Found in https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/storage/OfferStatus.sol#L8

Impact

The offer is using the wrong status.

Tools Used

Manual Analysis

Recommendations

Update the offer status when a taker has been matched to an offer and use the updated value throughout the code.