UserA can set userB as referrer and then userB can set userA as referrer.
This means UserA refers userB and userB refers userA which itself is contradictory as you can't refer someone who refers you.
Run this test inside PreMarketsTest
NOTE:- The function updateReferralInfo
itself has an error, it's updating the referralInfo
of _referrer
instead of msg.sender
, so first mitigate that issue to get the correct logs and proof of userA refers userB and userB refers userA
This will disrupts the entire referral program as everyone will use their own referral code, making the referral program useless and less and less people will promote the protocol as they will not get any refferal rewards.
Manual Review
Implement a new check condition inside updateReferralInfo
function, if the _referrer
has user
as its referrer
, then the user can't set _referrer
as its referrer
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.