Submission Details
Severity:
`PreMarkets::CreateOffer` stores wrong `StockType`
Summary
The CreateOffer function stores the StockType of the offer, however it is stores the wrong StockType
Vulnerability Details
StockInfo is being stored in the `CreateOffer function:
stockInfoMap[stockAddr] = StockInfo({
id: offerId,
stockStatus: StockStatus.Initialized,
@> stockType: params.offerType == OfferType.Ask ? StockType.Bid : StockType.Ask, //@audit low- incorrect StockType
authority: _msgSender(),
maker: makerAddr,
preOffer: address(0x0),
offer: offerAddr,
points: params.points,
amount: params.amount
});
the StockType that should be stored is the same as the OfferType, however the wrong one is being stored due to the following line:
stockType: params.offerType == OfferType.Ask ? StockType.Bid : StockType.Ask,
Impact
This might lead to inconsistency, wrong representation in the UI and unexpected errors.
Tools Used
manual review
Recommendations
change it to:
stockType: params.offerType == OfferType.Ask ? StockType.Ask : StockType.Bid
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.