Tadle
Tadle
DeFi
30,000 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

`SystemConfig::updateReferrerInfo` does not update referrer info correctly

honour

Summary

SystemConfig::updateReferrerInfo sets the referrer as the referrer to themselves instead of the referrer to the msg.sender and also forces the referrer rate to be equal to baseReferralRate in the case of no referralExtraRate so authority fee must always be 0.

Vulnerability Details

From the docs here, It's possible and expected for multiple users to have the same referrer, it is also possible to set a referrer rate below the base referrer rate(30%) .
However from the SystemConfig::updateReferrerInfo function implementation neither of these cases are possible.

Line 54 reverts if referrer rate is below baseReferralRate
Line 69 sets the referrer as the referrer to themselves instead of the referrer to the msg.sender

Impact

MEDIUM - The referrer info is not set correctly

Tools Used

Manual Review

Recommendations

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
if (_referrer == address(0x0)) {
revert Errors.ZeroAddress();
}
​
- if (_referrerRate < baseReferralRate) {
+ if (_referrerRate > baseReferralRate) {
revert InvalidReferrerRate(_referrerRate);
}
​
uint256 referralExtraRate = referralExtraRateMap[_referrer];
uint256 totalRate = baseReferralRate + referralExtraRate;
​
if (totalRate > Constants.REFERRAL_RATE_DECIMAL_SCALER) {
revert InvalidTotalRate(totalRate);
}
​
if (_referrerRate + _authorityRate != totalRate) {
revert InvalidRate(_referrerRate, _authorityRate, totalRate);
}
​
- ReferralInfo storage referralInfo = referralInfoMap[_referrer];
+ ReferralInfo storage referralInfo = referralInfoMap[_msgSender()];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
​
emit UpdateReferrerInfo(
msg.sender,
_referrer,
_referrerRate,
_authorityRate
);
}
Updates

Lead Judging Commences

0xnevi Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.