Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

withdrawer might loose funds due to inconsistency in `TokenManager::withdraw` as `msg.sender` is not guaranteed to be `_msgSender()`

Summary

TokenManager::withdraw sends native token to msg.sender instead of _msgSender(), it is not always guaranteed that msg.sender is _msgSender() as _msgSender() is based on context and can a totally different address if a trusted forwarder functionality is added

Vulnerability Details

TokenManager::withdraw sends native token to msg.sender instead of _msgSender() as we see here, it is not always guaranteed that msg.sender is the same as _msgSender() as _msgSender() is based on context and can a totally different address if a trusted forwarder functionality is added

Impact

possible loss of funds

Tools Used

Manual Review

Recommendations

it's beneficial to stick to one _msgSender() or msg.sender. in this case _msgSender() is recommended

Updates

Lead Judging Commences

0xnevi Lead Judge
12 months ago
0xnevi Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.