Submission Details
Severity:
Maker bonus as specified in the documentation for creating offers is unimplemented
Summary
The maker bonus functionality that's supposed to exist from the docs
Buy Points | Tadle Docs (gitbook.io)
Is not accounted for in any source files
Vulnerability Details
The Maker bonus functionality that's supposed to earn the offer creator additional royalty is not accounted in any of the functions responsible for carrying out Makers and Takers.
stockInfoMap[stockAddr] = StockInfo({
id: offerId,
stockStatus: StockStatus.Initialized,
stockType: params.offerType == OfferType.Ask
? StockType.Bid
: StockType.Ask,
authority: _msgSender(),
maker: makerAddr,
preOffer: address(0x0),
offer: offerAddr,
points: params.points,
amount: params.amount
});
//@audit no parameter to take maker bonus
emit CreateOffer(
offerAddr,
makerAddr,
stockAddr,
params.marketPlace,
_msgSender(),
params.points,
params.amount
);
Impact
The impact is that one of the financial aspects of the token trades is not accounted for in the smart contract, potentially breaking logic
Tools Used
manual analysis
Recommendations
Store the necessary detail in the structs in the MakerInfo.
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.