Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Typo issues in several Contracts

Summary

In this audit, we reviewed PreMarkets contract and its related imports and inheritances. We identified a typo issue where the contract name and its imports/heritances are inconsistent, using PreMarkets and PerMarkets interchangeably. This inconsistency could lead to confusion and potential errors in the deployment and interaction of the contract.

Vulnerability Details

The Premarktes contract, which is supposed to be PreMarkets, contains an obvious spelling error. Additionally, when importing and inheriting from other contracts or interfaces, this contract uses PreMarkets and PerMarkets interchangeably. This inconsistency may lead to confusion within the protocol. This issue happens in several other smart contracts, please check and modify.

contract PreMarktes
import {PerMarketsStorage} from "../storage/PerMarketsStorage.sol";
import {IPerMarkets, OfferInfo, StockInfo, MakerInfo, CreateOfferParams} from "../interfaces/IPerMarkets.sol";
contract PreMarktes is PerMarketsStorage, Rescuable, Related, IPerMarkets

Impact

Code Misinterpretation: Developers working with the contract may be confused by the inconsistency, leading to potential misinterpretation of the code.

Tools Used

Manual Review

Recommendations

Consistent Naming: Ensure that the contract name and all its imports and inheritances are consistently named. If the contract is intended to be PreMarkets, all references should use PreMarkets. Similarly, if PerMarkets is the intended name, update the contract name to PerMarkets.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] finding-Typos

Typos are at most informational and does not highlight a direct smart contract vulnerability

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.