Submission Details
Severity:
no check whether "stockStatus" is already finished in settleAskTaker.
Summary
there is no check in settleAskTaker whether stockInfo.stockStatus is already finished or not.
Vulnerability Details
function settleAskTaker(
address _offer,
address _stock,
uint256 _settledPoints,
uint256 _settledPointTokenAmount
) external onlyDeliveryPlace(tadleFactory, _msgSender()) {
StockInfo storage stockInfo = stockInfoMap[_stock];
OfferInfo storage offerInfo = offerInfoMap[_offer];
offerInfo.settledPoints = offerInfo.settledPoints + _settledPoints;
offerInfo.settledPointTokenAmount =
offerInfo.settledPointTokenAmount +
_settledPointTokenAmount;
@ stockInfo.stockStatus = StockStatus.Finished;
emit SettledBidTaker(
_offer,
_stock,
_settledPoints,
_settledPointTokenAmount
);
}
Impact
if stockInfo.stockStatus is already finished then settleAskTaker will not work.
Tools Used
Recommendations
there should be a check on settleAskTaker for stockInfo.stockStatus is finished or not.
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.