Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Introduce error for points

Summary

The input validation check has a mismatch between the error condition and the message.

Vulnerability Details

The following code snippet shows the issue:

if (params.points == 0x0 || params.amount == 0x0) {
revert Errors.AmountIsZero();
}

The condition checks for both points and amount being zero, but the error message only refers to the amount.

Impact

The overall impact is low, as it doesn't affect the contract's security or core functionality.

Tools Used

Manual code review

Recommendations

  1. Introduce PointsIsZero error

    if (params.points == 0x0) revert Errors.PointsIsZero();
    if (params.amount == 0x0) revert Errors.AmountIsZero();
Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.