Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

In SystemConfig::updateReferrerInfo, anyone except the referrer is authorized to call this function

0xrststn

Summary

In SystemConfig::updateReferrerInfo, anyone is authorized to set a referrer settings except the referrer himself

Vulnerability Details

SystemConfig::updateReferrerInfo reverts if the caller is the referrer which settings are going to be updated:

if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}

Impact

Anyone except the one getting his settings updated can call this function.

Tools Used

Manual Review

Recommendations

Update the following in SystemConfig::updateReferrerInfo:

- if (_msgSender() == _referrer) {
+ if (_msgSender() != _referrer) {
revert InvalidReferrer(_referrer);
}
Updates

Lead Judging Commences

0xnevi Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.