Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Users are always referrers for themselves

pontifex

Summary

Users always pay fees to themselves instead of referrals since the referrer address and users address match. In turn referrals do not receive fees at all.

Vulnerability Details

The updateReferrerInfo function saves _referrer as an address to collect fees from _referrer.

function updateReferrerInfo(
>> address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
) external {
<...>
>> ReferralInfo storage referralInfo = referralInfoMap[_referrer];
>> referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;

When users should pay fees the _msgSender() is used as parameter to find referralInfo:
PreMarkets.sol:

ReferralInfo memory referralInfo = systemConfig.getReferralInfo(
_msgSender()
);

This way referrals can not receives fees

Impact

Fee losses

Tools used

Manual Review

Recommendations

Consider using _msgSender() as referralInfo.referrer in the updateReferrerInfo function

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.