Inconsistent Pausing Mechanism Allows `Deposits` When `TokenManager`Contract is Paused
Summary: The tillIn function allows token deposits even in the scenario that the contract is paused, leading to inconsistent behaviour and potential security risks
Vulnerability Details: The TokenManager contract employs a pausing mechanism to halt critical operations during emergencies or maintenance. like the withdrawal of tokens However, the tillIn function, responsible for depositing tokens into the capital pool, does not adhere to this pausing mechanism. This inconsistency allows users to continue depositing tokens while withdrawals are halted, which can lead to confusion and potential fund management issues
Impact:
Inconsistent State Management: Users can deposit tokens while withdrawals are paused, leading to an imbalance in fund management.
Security Risks: If there is an identified vulnerability that requires pausing all operations, allowing deposits could exacerbate the problem
Tools Used: Manual Review
Recommendations: Add the whenNotPaused modifier to the tillIn function.
Lead Judging Commences
[invalid] finding-Rescuable-pause-no-effect
I believe this is informational and non-acceptable severity because: - A single pause on withdraw to be sufficient to pause the markets during times of emergencies, given that is the only function where collateral/point tokens/native ETH can be pulled from market transactions. - Every tadle market place can be switched offline by the admin via [`updateMarketPlaceStatus`](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L160-L171) and is checked in market actions via [`checkMarketPlaceStatus`](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/libraries/MarketPlaceLibraries.sol#L54-L67) to be online. This prevents many major market actions including the creation, listing and settlement of offers.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.