No access control check in updateReferrerInfo, anyone can update anyone's referral info
Summary
No access control check in updateReferrerInfo, anyone can update anyone's referral info
Vulnerability Details
When updating a referrer's info, anyone can update it for anyone else, which would result in people gaming the referral system in the function updateReferrerInfoin SystemConfig.sol
Impact
The referral system will simply not work as designed because of the lack of access control, i.e the msg.sender should only be able to update their own referrer info
Tools Used
Manual review
Recommendations
Change line #69 to:
Lead Judging Commences
finding-SystemConfig-updateReferrerInfo-msgSender
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.