Tadle

Tadle

Tadle

DeFi
30,000 USDC
Submission Details
Severity: low
Valid

Missing Token Manager Check in `approve` Function of CapitalPool Contract

Updates

Lead Judging Commences

0xnevi Lead Judge 17 days ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-CapitalPool-approve-missing-access-control

This is at most low severity, even though giving max approvals shouldn't be permisionless, the respective tokenManager address is retrieved from the TadleFactory contract whereby the trusted guardian role is responsible for deploying such contracts as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/factory/TadleFactory.sol#L68). Since the user still has to go through the PreMarkets/DeliveryPlace contracts to perform market actions, this max approval cannot be exploited.

Support

FAQs

Can’t find an answer? Join our Discord or follow us on Twitter.