Submission Details
Severity:
getOfferInfo does not return explicitly
Summary
getOfferInfo in DeliveryPlace.sol uses implicit return
Vulnerability Details
Most functions in the code that return values do it explicitly, while getOfferInfodoesn't.
Consider returning explicitly, which may reduce future errors or prevent regressions if the code changes since the contract is upgradeable.
function getOfferInfo(
address _offer
)
internal
view
returns (
OfferInfo memory offerInfo,
MakerInfo memory makerInfo,
MarketPlaceInfo memory marketPlaceInfo,
MarketPlaceStatus status
)
{
IPerMarkets perMarkets = tadleFactory.getPerMarkets();
ISystemConfig systemConfig = tadleFactory.getSystemConfig();
offerInfo = perMarkets.getOfferInfo(_offer);
makerInfo = perMarkets.getMakerInfo(offerInfo.maker);
marketPlaceInfo = systemConfig.getMarketPlaceInfo(
makerInfo.marketPlace
);
status = MarketPlaceLibraries.getMarketPlaceStatus(
block.timestamp,
marketPlaceInfo
);
}
Impact
Low, it does not affect the contract as it is but may affect future versions because the code is upgradeable and other functions in the code do return explicitly.
Tools Used
Manual review
Recommendations
Add return in the end of getOfferInfo:
returns (offerInfo, makerInfo, marketPlaceInfo,status);
Prize pool breakdown
Total prize
27,750 USDC
nSLOC
1,22923 USDC / LOC
25,000 USDC
2,750 USDC
2,250 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.