Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: medium
Invalid

Inconsistent State Checks in DeliveryPlace contract

Hello Tadle,

  • The function settleAskTaker checks stockInfo.stockStatus != StockStatus.Initialized and then allows the operation to proceed if this condition is false. However, similar checks are missing in other functions like closeBidOffer and closeBidTaker.

  • This could result in state inconsistencies if an offer or stock is in an unexpected status.

Solution: Ensure consistent and comprehensive state checks across all functions. If a function expects a certain status or condition to be true before proceeding, explicitly check for it and handle any exceptions.

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.