The `depositAmount` calculation in the `abortBidTaker()` function is incorrect
Summary
The depositAmount calculation in the abortBidTaker() function is incorrect, as the protocol uses stockInfo.points * preOfferInfo.points / preOfferInfo.amount.
Vulnerability Details
In the abortBidTaker() function, the protocol incorrectly calculates depositAmount using stockInfo.points * preOfferInfo.points / preOfferInfo.amount. This calculation will result in 0, preventing the user from aborting the bid taker.
Impact
The user cannot abort the bid taker.
Tools Used
Recommendations
The recommended fix is to calculate depositAmount using depositAmount = preOfferInfo.amount * stockInfo.points / preOfferInfo.points.
Lead Judging Commences
finding-PreMarkets-abortBidTaker-amount-wrong-StockInfo-points
Valid high severity, due to incorrect computation of `depositAmount` within `abortBidTaker`, when aborting bid offers created by takers, the collateral refund will be completely wrong for the taker, and depending on the difference between the value of `points` and `amount`, it can possibly even round down to zero, causing definite loss of funds. If not, if points were worth less than the collateral, this could instead be used to drain the CapitalPool contract instead.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.