Tadle

​

The `TadleFactory` constructor fails to include a check ensuring that the `_guardian` address is not set to the zero address (`address(0x0)`). This oversight can result in the contract being initialized with an invalid guardian, which would impede the contract’s ability to perform critical operations, such as deploying related contracts.

​

​

​

In the `TadleFactory` contract, the `guardian` address is assigned during contract deployment via the constructor:

​

constructor(address _guardian) {

}

​

However, the constructor does not include a validation check to ensure that the `_guardian` address is not the zero address (`address(0x0)`). This could lead to situations where the guardian, who is supposed to have special privileges (such as deploying other related contracts), is set to an invalid address. As a result, the functions relying on the guardian's authority would be rendered inoperative, leading to potential operational failures.

​

​

If the `guardian` address is set to the zero address, the contract would be unable to execute any functions restricted to the guardian, such as deploying related contracts. This could severely disrupt the intended functionality of the `TadleFactory` contract, rendering it incapable of managing other critical contract deployments. The inability to perform these essential operations could have significant operational and financial implications.

​

​

- **Manual Code Review**: Further analysis and verification of the issue.

​

​

To prevent the possibility of assigning an invalid guardian address, it is recommended to add a validation check in the constructor to ensure the `_guardian` address is not `address(0x0)`. The updated code should look like this:

​

constructor(address _guardian) {

}

​

This change will ensure that the guardian role is always assigned to a valid address, maintaining the contract's functionality and security.

​

​

​

The severity of this issue is classified as **medium**. While it does not pose an immediate threat to the security of the contract, it can lead to significant operational issues if the contract is deployed with an invalid guardian address. Implementing the recommended fix will ensure the proper functioning of the contract and prevent potential disruptions.