Tadle

​

The `initialize` function within the `SystemConfig` contract updates critical state variables (`basePlatformFeeRate` and `baseReferralRate`) but fails to emit events reflecting these changes. The absence of event emissions can hinder the transparency and traceability of important state changes within the contract.

​

​

The `initialize` function is designed to set the `basePlatformFeeRate` and `baseReferralRate` values upon initialization by the contract owner. However, the function does not emit any events after updating these values. Emitting events is a best practice in smart contract development as it allows external observers, such as off-chain services and users, to track changes in the contract state.

​

​

function initialize(

) external onlyOwner {

}

​

​

Slither, a static analysis tool, detected that the `initialize` function should emit events when updating the `basePlatformFeeRate` and `baseReferralRate` variables. The lack of events means these updates are not easily observable, which can be problematic in terms of auditability and transparency.

​

Reference: [Slither Detector Documentation on Missing Events](https://github.com/crytic/slither/wiki/Detector-Documentation#missing-events-arithmetic)

​

​

The failure to emit events can lead to several issues:

1. **Reduced Transparency:** Stakeholders cannot easily track changes to critical state variables, leading to potential trust issues.

2. **Difficulty in Auditing:** Without events, off-chain services and tools that rely on event logs will have a harder time monitoring contract activity.

3. **Potential for Disputes:** In cases where the contract's behavior is disputed, the absence of event logs can complicate the process of verifying state changes.

​

​

- Slither static analysis tool.

- Manual code review.

​

​

To enhance transparency and auditability, it is recommended to emit events whenever critical state variables like `basePlatformFeeRate` and `baseReferralRate` are updated. This can be achieved by adding the following event emissions:

​

​

event UpdateBasePlatformFeeRate(uint256 newBasePlatformFeeRate);

event UpdateBaseReferralRate(uint256 newBaseReferralRate);

​

function initialize(

) external onlyOwner {

​

}

​

These events will provide an on-chain record of the changes, improving the protocol's transparency and making it easier for external tools and stakeholders to monitor updates.

​

​

This issue is classified as **low** severity. While it does not directly affect the contract's security or functionality, it impacts the protocol's transparency and traceability, which are critical aspects of a robust and trustworthy system. Addressing this issue will help maintain user trust and improve the contract's auditability.