Tadle

​

The `guardian` state variable in the `TadleFactory` contract is assigned during contract construction and is not intended to change. Declaring this variable as `immutable` can save gas and reinforce its immutability, ensuring that the `guardian` address remains constant throughout the contract's lifecycle.

​

​

​

The `guardian` state variable is assigned a value in the constructor and remains unchanged afterward. Declaring it as `immutable` offers two benefits:

1. **Gas Optimization**: The `immutable` keyword allows the variable to be stored directly in the contract’s code, which reduces the gas cost associated with accessing this variable.

2. **Enforcing Immutability**: Declaring the variable as `immutable` makes it clear that this value will not change after the initial assignment, enhancing the security and clarity of the contract.

​

​

Current implementation:

​

address internal guardian;

​

constructor(address _guardian) {

}

​

Recommended update:

​

address internal immutable guardian;

​

constructor(address _guardian) {

}

​

​

Slither, a static analysis tool, flagged the `guardian` variable as a candidate for the `immutable` keyword since it is assigned in the constructor and is not modified thereafter.

​

​

- **Gas Optimization**: Declaring `guardian` as `immutable` will slightly reduce the gas costs when accessing this variable.

- **Security and Readability**: Using `immutable` signals the intent that the `guardian` address is meant to remain constant, reducing the risk of errors or misunderstandings in future contract modifications.

​

​

- **Slither**: Identified the opportunity to declare the `guardian` variable as `immutable`.

​

​

Update the `guardian` state variable to be `immutable` for enhanced gas efficiency and to clearly indicate its immutability.

​

​

address internal immutable guardian;

​

constructor(address _guardian) {

}

​

​

​

The issue is classified as **low** severity because it does not pose a direct security threat. However, implementing the recommendation can optimize gas usage and reinforce best practices for code clarity and security.