Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

No access control in the `CapitalPool.approve()` function.

eeyore

Summary

There is no access control in the CapitalPool.approve() function which contradicts the NatSpace documentation of this function:

File: CapitalPool.sol
19: /**
20: * @dev Approve token for token manager
21: * @notice only can be called by token manager
22: * @param tokenAddr address of token
23: */
24: function approve(address tokenAddr) external {

Impact

  • Invalid validation.

Tools Used

Manual review.

Recommendations

Add access control to the CapitalPool.approve() function.

Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-CapitalPool-approve-missing-access-control

This is at most low severity, even though giving max approvals shouldn't be permisionless, the respective tokenManager address is retrieved from the TadleFactory contract whereby the trusted guardian role is responsible for deploying such contracts as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/factory/TadleFactory.sol#L68). Since the user still has to go through the PreMarkets/DeliveryPlace contracts to perform market actions, this max approval cannot be exploited.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.