The abortBidTaker()
function in the PreMarkets
contract is intended to abort bid taker
. However, the function does not verify that the stock
being aborted is of the Bid
type. This oversight can lead to unintended behavior, allowing non-bid
stocks to be aborted.
closeBidTaker()
ensures that the stock type must Bid
:
However, abortBidTaker()
function does not check if the stock being aborted is of the Bid
type.
The function should explicitly verify that the stock type is Bid
before proceeding with the abortion process.
Non-bid stocks could be aborted, violating the intended functionality and rules of the platform.
Manual Review
Add a check to ensure the stock type is Bid
before aborting
Low severity, the check is indeed missing for `abortBidTaker`, however, this would be contingent on user error and the funds are not locked, given admin can rescue them via `Rescuable.sol`
Leaving high severity for now but will leave open for appeals. Technically, users can choose not to transact this type offers if they are aware of such undercollaterized relisted offers, in which case it will have no impact. However, if subsequent takers transact this relisted offers, this can allow profits without having to settle any points.
Low severity, the check is indeed missing for `abortBidTaker`, however, this would be contingent on user error and the funds are not locked, given admin can rescue them via `Rescuable.sol`
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.