Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: high
Valid

Incorrect updating of `referralInfoMap` results in the referral mechanism being corrupted

Summary

The updateReferrerInfo() function allowing any user to call it and set the referral relationship to referer => referralInfo, resulting in the referrer of an account is the account itself. This vulnerability enables anyone to change another user's referrer, leading to a corrupted referral system.

Vulnerability Details

The updateReferrerInfo() function allows updating a user's referral information. The referral data is stored in the referralInfoMap(user => referralInfo) mapping, which tracks referral information for each user.

The function incorrectly uses _referrer as the key in the referralInfoMap mapping (L69), which should instead represent the user account whose referral information is being updated. This results in the mapping storing referrer => referralInfo, meaning that the referrer is mapped to itself:

File: SystemConfig.sol
41: function updateReferrerInfo(
42: address _referrer,
43: uint256 _referrerRate,
44: uint256 _authorityRate
45: ) external {
46: if (_msgSender() == _referrer) {
47: revert InvalidReferrer(_referrer);
48: }
...
69:> ReferralInfo storage referralInfo = referralInfoMap[_referrer];
70:> referralInfo.referrer = _referrer;
71: referralInfo.referrerRate = _referrerRate;
72: referralInfo.authorityRate = _authorityRate;

Impact

Allowing unauthorized users to alter referral relationships, leading to a corrupted referral system.

Tools Used

vscode

Recommendations

- ReferralInfo storage referralInfo = referralInfoMap[_referrer];
+ ReferralInfo storage referralInfo = referralInfoMap[_msgSender()];
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.