Incorrect referrer information update in updateReferrerInfo()
Summary
The trader can update his own referrer and related platform fee distribution rate. But updateReferrerInfo() allows anyone can update all traders' referrer information, and every trader's referrer will be set to himself.
Vulnerability Details
In updateReferrerInfo(), the trader can update his own referrer and related platform fee distribution rate.
The problem is that when the trader updateReferrerInfo(), the trader will update referrer's referrer not the traders' referrer.
ReferralInfo storage referralInfo = referralInfoMap[_referrer]
This is incorrect, the referralInfo should comes from referralInfoMap[msg.sender]
Impact
Anyone can update all trader's referral rate. This should not be allowed.
Tools Used
Manual
Recommendations
Change referralInfo = referralInfoMap[_referrer] to referralInfo = referralInfoMap[msg.sender]
Lead Judging Commences
finding-SystemConfig-updateReferrerInfo-msgSender
Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.