Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

systemConfig::updateReferrerInfo() updates `referralInfoMap` on _referrer address instead of msg.sender

0xaraj

Summary

systemConfig::updateReferrerInfo() updates referralInfoMap on _referrer address instead of msg.sender

Vulnerability Details

A user can updates his referrerInfo using systemConfig::updateReferrerInfo(), but the problem is it updates the referralInfoMap mapping on _referrer address instead of msg.sender

function updateReferrerInfo(address _referrer, uint256 _referrerRate, uint256 _authorityRate) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
...
@> ReferralInfo storage referralInfo = referralInfoMap[_referrer];
referralInfo.referrer = _referrer;
referralInfo.referrerRate = _referrerRate;
referralInfo.authorityRate = _authorityRate;
}

This is a problem because any user will be able to update the referrerInfo of any other user. A malicious user can take advantage of this and set the referrerRate & authorityRate of an honest user. As result, referrer & authority will receive wrong amount of ReferralBonus when creating taker(preMarket.createTaker()).

function _updateReferralBonus(
uint256 platformFee,
uint256 depositAmount,
address stockAddr,
MakerInfo storage makerInfo,
ReferralInfo memory referralInfo,
ITokenManager tokenManager
) internal returns (uint256 remainingPlatformFee) {
if (referralInfo.referrer == address(0x0)) {
remainingPlatformFee = platformFee;
} else {
@> uint256 referrerReferralBonus = platformFee.mulDiv(
referralInfo.referrerRate, Constants.REFERRAL_RATE_DECIMAL_SCALER, Math.Rounding.Floor
);
​
/**
* @dev update referrer referral bonus
* @dev update authority referral bonus
*/
@> tokenManager.addTokenBalance(
TokenBalanceType.ReferralBonus, referralInfo.referrer, makerInfo.tokenAddress, referrerReferralBonus
);
​
@> uint256 authorityReferralBonus = platformFee.mulDiv(
referralInfo.authorityRate, Constants.REFERRAL_RATE_DECIMAL_SCALER, Math.Rounding.Floor
);
@> tokenManager.addTokenBalance(
TokenBalanceType.ReferralBonus, _msgSender(), makerInfo.tokenAddress, authorityReferralBonus
);
​
remainingPlatformFee = platformFee - referrerReferralBonus - authorityReferralBonus;
}
}

Impact

Referrer & authority can receive wrong amount of ReferralBonus

Tools Used

Manual Review

Recommendations

Use msg.sender instead of _referrer

- ReferralInfo storage referralInfo = referralInfoMap[_referrer];
+ ReferralInfo storage referralInfo = referralInfoMap[msg.sender];
Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!