Incorrect accounting lable in `settleAskMaker()`
Vulnerability Details 🔍 && Impact 📈
At DeliveryPlace.sol at settleAskMaker(), makerRefundAmount is uesed in addTokenBalance() with the type TokenBalanceType.SalesRevenue. It should be TokenBalanceType.MakerRefund.
Coudnt find any negative consequence on the users as SalesRevenue and MakerRefund both have the same collateral units. Impact is incorrect state handling.
Recommendations 🎯
Track it as MakerRefund, the line is here
Lead Judging Commences
finding-DeliveryPlace-settleAskMaker-addTokenBalance-wrong-TokenBalanceType
Valid low severity, while the token type inputted is wrong, userTokenBalanceMap is still incremented appropriately, so users can still withdraw their funds. So this would technically only affect accounting and public view functions.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.