Tadle

Tadle
DeFiFoundry
27,750 USDC
View results
Submission Details
Severity: low
Invalid

Missing `receive()` function in TokenManager contract prevents conversion of wrapped asset back to native

Summary

TokenManager is used to interact with native asset as well as its wrapped version. A missing receive()function means that the contract cannot convert wrapped asset back to native asset as the contract cannot receive it.

Vulnerability Details

Missing receive()function in TokenManger.sol bricks the withdrawfunction.

Impact

withdraw()cannot be called for when _tokenAddress == wrappedNativeToken

Tools Used

Manual Review

Recommendations

Consider adding receive()to the TokenManager contract.

Updates

Lead Judging Commences

0xnevi Lead Judge over 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement
Assigned finding tags:

[invalid] finding-TokenManager-no-native-ETH-receive

Invalid, TokenManager is the implementation contract of 9the transparent upgradeable proxy, as can seen by the comments [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/proxy/UpgradeableProxy.sol#L15). The receive payable is implemented as seen [here](https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/proxy/UpgradeableProxy.sol#L37)

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!