Tadle

Summary

The updateReferrerInfo function in the SystemConfig.sol contract allows any user to update the referral rate and authority rate of other users. This flaw can be exploited to tamper with referral rewards calculations, which could impact the protocol's reward distribution system.

Vulnerability Details

The updateReferrerInfo function is intended to update the referral and authority rates for a given referrer. However, the current implementation contains a critical flaw:

1. Lack of Access Control: The function does not verify whether the caller has the appropriate permissions to update referral rates. As a result, any user can invoke this function to change the referral and authority rates for any other referrer.

2. Potential Impact: Since the referral and authority rates are used by the protocol to calculate and allocate referral rewards, unauthorized changes can lead to incorrect reward distribution. This can result in financial loss or exploitation of the reward system.

Proof of Concept

The updateReferrerInfo function allows arbitrary updates to the referral and authority rates, as shown below:

In this implementation, there are no access control mechanisms to prevent unauthorized users from updating referral information.

Impact

• Unauthorized Changes: Any user can update the referral and authority rates of other users, potentially leading to unauthorized changes in referral rewards.

• Financial Exploitation: Incorrect reward calculations due to tampered rates can result in financial losses for the protocol and its users.

Tools Used

Manual Review

Recommendations

Implement Access Control: Restrict the updateReferrerInfo function to authorized users only.