Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing Event Emission in Critical Function

0xnbvc

Vulnerability Details

A critical function updateMarketPlaceStatus() in SystemConfig.sol fails to emit an event after making important state changes. This omission violates best practices for smart contract development and reduces the contract's transparency and auditability.

SystemConfig.sol#L160-L171

function updateMarketPlaceStatus(
string calldata _marketPlaceName,
MarketPlaceStatus _status
) external onlyOwner {
address marketPlace = GenerateAddress.generateMarketPlaceAddress(
_marketPlaceName
);
MarketPlaceInfo storage marketPlaceInfo = marketPlaceInfoMap[
marketPlace
];
marketPlaceInfo.status = _status;
>> //@audit no event emission
}

Impact

The lack of event emission in this function results in:

  1. Reduced off-chain observability of important state changes

  2. Difficulty in tracking and auditing contract activities

  3. Potential issues for front-end applications or other contracts that rely on events for updates

Recommendation

Implement an appropriate event emission at the end of the function.

Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.