Remaining platform fee after distributions is stuck on the contract
Summary
makerInfo.platformFee is accumulated overtime if there are any leftovers from platform fee after the referrer and offer authority rewards are distributed. This remaining amount is never used and cannot be withdrawn.
Vulnerability Details
The stuck funds can be accessed by upgrading the contracts but it is recommneded to have a control over it right from the start.
Impact
The value stored in makerInfo.platformFee has no accessibilty. These funds are stuck on the contract.
Tools Used
Manual Review
Recommendations
Create a new function wherein the funds within the makerInfo.platformFee can be utilised.
Lead Judging Commences
finding-PreMarkets-platformFee-no-withdraw-functionality
Low severity, this can be done using the `Rescuable.sol` contract. Arguably there is no errors here given the `platformFee` variable can represent the historical fees that the protocol has accumulated and need not be updated when fees are withdrawn. However, I believe a more explicit function can be valuable to be more transparent regarding withdrawals. However, I will leave this issue open for escalation for debates because I can see it as arguably invalid as well, but I see no arguments for it being medium severity since there is an alternative to retrieve platform fees, assuming admins are trusted.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.