Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Missing access control in ```SystemConfig::updateReferrerInfo``` leads to unauthorized updating of the referrer info

kiteweb3

Summary

The SystemConfig::updateReferrerInfo allows updating the referrer rate without any access control restrictions. This means any user interacting with the contract can modify the referrer rate, altering the economic incentives within the system.

Link: https://github.com/Cyfrin/2024-08-tadle/blob/04fd8634701697184a3f3a5558b41c109866e5f8/src/core/SystemConfig.sol#L41C4-L80C6

Vulnerability Details

The absence of access control mechanisms, such as the onlyOwner modifier on the updateReferrerInfo function exposes the contract to unauthorized modifications of critical parameters. This oversight enables any address to call the function and change the referrer rate, bypassing intended governance or administrative controls.

function updateReferrerInfo(
address _referrer,
uint256 _referrerRate,
uint256 _authorityRate
@> ) external {
if (_msgSender() == _referrer) {
revert InvalidReferrer(_referrer);
}
​
... omitted code
​
}

Impact

Malicious actors can exploit this flaw to set referrer rates to their advantage, disrupting the intended economic model of the platform.

Tools Used

Manual review

Recommendations

Implement an access control adding the onlyOwner modifier.

- function updateReferrerInfo(address _referrer, uint256 _referrerRate, uint256 _authorityRate) external {
+ function updateReferrerInfo(address _referrer, uint256 _referrerRate, uint256 _authorityRate) external onlyOwner{
Updates

Lead Judging Commences

0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-SystemConfig-updateReferrerInfo-msgSender

Valid high severity. There are two impacts here due to the wrong setting of the `refferalInfoMap` mapping. 1. Wrong refferal info is always set, so the refferal will always be delegated to the refferer address instead of the caller 2. Anybody can arbitrarily change the referrer and referrer rate of any user, resulting in gaming of the refferal system I prefer #1500 description the most, be cause it seems to be the only issue although without a poc to fully describe all of the possible impacts

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.