Tadle
Tadle
DeFiFoundry
27,750 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Incomplete interface definition leads to potential integration issues

0xnbvc

Vulnerability Details

The IDeliveryPlace interface in IDeliveryPlace.sol is significantly incomplete compared to the actual implementation of the DeliveryPlace contract. The interface is missing crucial elements such as events, errors, and functions that are present in the actual contract.

For instance, the interface is missing important functions like:

function closeBidOffer(address _offer) external;
function closeBidTaker(address _stock) external;
function settleAskMaker(address _offer, uint256 _settledPoints) external;
function settleAskTaker(address _stock, uint256 _settledPoints) external;

It also lacks critical events such as CloseBidOffer, CloseBidTaker, SettleAskMaker, and SettleAskTaker, which are essential for tracking the state changes in the contract.

Furthermore, the interface is missing error definitions like FixedRatioUnsupported, InsufficientRemainingPoints, and InvalidOfferStatus, which are crucial for proper error handling.

Impact

Disruption to the protocol's functionality or availability. This incomplete interface definition can lead to several serious issues:

  1. Integration difficulties: Other contracts or external systems relying on this interface will have an incomplete view of the DeliveryPlace contract's capabilities, leading to integration errors.

  2. Reduced functionality: Developers using this interface may not be aware of all available functions, potentially underutilizing the contract.

  3. Inadequate error handling: Missing error definitions can result in unexpected behavior when errors occur, as calling contracts won't be able to properly catch and handle these errors.

  4. Event monitoring issues: The absence of event definitions in the interface means that systems monitoring the contract may miss critical state changes.

Recommendations

Update the IDeliveryPlace interface to accurately reflect all functions, events, and errors present in the DeliveryPlace contract.
Here's the complete interface definition obtained from forge inspect DeliveryPlace abi --pretty:

interface DeliveryPlace {
type OfferType is uint8;
​
error AlreadyInitialized();
error EnforcedPause();
error ExpectedPause();
error FixedRatioUnsupported();
error InsufficientRemainingPoints();
error InvaildMarketPlaceStatus();
error InvalidOfferStatus();
error InvalidOfferType(OfferType _targetType, OfferType _currentType);
error InvalidPoints();
error InvalidStock();
error InvalidStockStatus();
error InvalidStockType();
error MathOverflowedMulDiv();
error OwnableInvalidOwner(address owner);
error OwnableUnauthorizedAccount(address account);
error TransferFailed();
error Unauthorized();
​
event CloseBidOffer(
address indexed _marketPlace, address indexed _maker, address indexed _offer, address _authority
);
event CloseBidTaker(
address indexed _marketPlace,
address indexed _maker,
address indexed _stock,
address _authority,
uint256 _userCollateralFee,
uint256 _pointTokenAmount
);
event OwnershipTransferred(address indexed previousOwner, address indexed newOwner);
event Paused(address account);
event Rescue(address to, address token, uint256 amount);
event SetPauseStatus(bool status);
event SettleAskMaker(
address indexed _marketPlace,
address indexed _maker,
address indexed _offer,
address _authority,
uint256 _settledPoints,
uint256 _settledPointTokenAmount,
uint256 _makerRefundAmount
);
event SettleAskTaker(
address indexed _marketPlace,
address indexed _maker,
address indexed _stock,
address _preOffer,
address _authority,
uint256 _settledPoints,
uint256 _settledPointTokenAmount,
uint256 _collateralFee
);
event Unpaused(address account);
​
function closeBidOffer(address _offer) external;
function closeBidTaker(address _stock) external;
function initializeOwnership(address _newOwner) external;
function owner() external view returns (address);
function paused() external view returns (bool);
function renounceOwnership() external;
function rescue(address to, address token, uint256 amount) external;
function setPauseStatus(bool pauseSatus) external;
function settleAskMaker(address _offer, uint256 _settledPoints) external;
function settleAskTaker(address _stock, uint256 _settledPoints) external;
function tadleFactory() external view returns (address);
function transferOwnership(address newOwner) external;
}
Updates

Lead Judging Commences

0xnevi Lead Judge
about 1 year ago
0xnevi Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.