Tadle

Summary

In the Turbo settle type logic, originOfferInfo is declared as memory instead of storage. This means any changes to originOfferInfo (like setting abortOfferStatus) will not persist.

Vulnerability Details

The function updates offerInfoMap and stockInfo.offer, but doesn't update any state in makerInfo or the original offerInfo. This could lead to inconsistent state across related entities. In the Turbo settle type logic, originOfferInfo is declared as memory instead of storage. This means any changes to originOfferInfo (like setting abortOfferStatus) will not persist.

The function declares originOfferInfo as a memory variable. It then attempts to update abortOfferStatus on this memory variable. The line originOfferInfo.abortOfferStatus = AbortOfferStatus.SubOfferListed; appears to update the offer's status, but this change is only made to the temporary memory copy.

Impact

This means that despite the code's intention, the abortOfferStatus of the original offer is never actually updated.

Tools Used

Manual Review

Recommendations

Change the declaration to use storage instead of memory