Tadle

Summary

The closeOffer function updates offerInfo.offerStatus to Canceled, but doesn't update the corresponding stockInfo. This leaves the stockInfo.offer still pointing to a canceled offer, potentially leading to inconsistent state. When an offer is closed, related state in stockInfo (like stockInfo.offer) should be reset or updated to reflect that the offer no longer exists.

Vulnerability Details

The offerInfo.offerStatus is updated to Canceled. However, the corresponding stockInfo is not updated to reflect this change. In a system where Stocks and Offers are related entities, it's crucial to keep their states consistent with each other. The function cancels an offer but doesn't update the stock to indicate that it no longer has an active offer.

Impact

This leads to a situation where the offer is marked as canceled, but the stock still references it as an active offer.

Tools Used

Manual Review

Recommendations

When an offer is canceled, the function should:

• Update the offerInfo to mark it as canceled.

• Update the stockInfo to remove the reference to the canceled offer or mark it as inactive.

• Potentially update any other related state (e.g., in makerInfo) to reflect the offer cancellation.