The SystemConfig
smart contract does not implement uniqueness for marketplace names during creation. This issue lead to multiple marketplaces being created with the same name, causing potential confusion and operational issues.
The createMarketPlace
function lacks a check to ensure that marketplace names are unique. As a result , it is possible to create multiple marketplaces with the same name. This can lead to:
Difficulty in differ and managing multiple marketplaces with identical names.
Conflicts in handling data and operations associated with these marketplaces.
While the issue does not directly effect funds or cause severe disruptions, it can result in operational challenges and confusion in managing and differentiating between marketplaces.
Manual Code Review
Add a Mapping to Track Used Marketplace Names:
Create a mapping to keep track of which marketplace names have been used to prevent duplicates.
Update createMarketPlace
Function:
Add a function to check if the marketplace name has already been used before allowing the creation of a new marketplace. Store the name in mapping as used upon successful creation.
Invalid, admins trusted to create marketplaces accordingly with appropriate inputs, as stated in READ.ME. If they do, there will be no issues.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.